Trims off effect layers, makes rendering a bit more sane #295
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The existing multiplier is lower then layer values encoraged by byond, so it breaks easy. Hopefully a larger value will help here.
|
I had to bump the multiplier up significantly, I am like 90% sure this is starting to edge on floating point rounding errors. Please advise NVM I'm doing it Done |
LemonInTheDark
changed the title
|
@LemonInTheDark I've fixed the pipeline. Please update the PR to the latest main to proceed with CI |
SpaiR
approved these changes
Jul 5, 2024
…ttle-for-white-rooms-and-hollow-doors
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The existing multiplier is lower then layer values encouraged by byond when combined with layering defines, so it breaks easy. I'm removing effect layers which should make the value at least a little more sane (though at a max of 4999 there is still risk of intermixing, should we be using float64 or someodd?)
I was not able to get the build process to work, so this is unfortunately untested. Apologies. Should close #292
Type of change